Repository navigation
Remove auth workspace picker limit and support ID search - #7071
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 074c284
Top 6 slowest tests (at least 2 minutes):
|
Every row now shows the workspace ID, so bold alone no longer made the highlighted row stand out. Add the same marker the profile picker uses, render nameless workspaces by ID without a stray leading space, and say in the label that ID search works. Isolate the picker tests from the developer's DATABRICKS_* environment and pin the rendered list with a golden snapshot. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Oct 15, 2026
Keep the golden snapshot LF on Windows checkouts, matching libs/cmdio/cmdiotest/testdata. Clear only DATABRICKS_CONFIG_PROFILE instead of the whole environment: without SystemRoot, Windows can't open the httptest listener. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
databricks auth loginagainst an account host lists the account's workspaces and asks you to pick one. Accounts with more than 50 workspaces only saw the first 50, so the workspace you needed could be missing, and the only way out was rerunning with--workspace-id. Search also only matched names, so knowing the ID didn't help.Fixes BR-2184, including the picker used by
ug configure.Changes
Before: the picker showed the first 50 workspaces and only searched by name.
Now: the picker includes every workspace and you can search by name or ID.
promptForWorkspaceSelection. The SDK list call has no pagination or search parameters, so it's still one request and filtering stays local.newWorkspaceSearcher, which matches case-insensitive name substrings and ID substrings. An exact ID match narrows the list to that workspace, so typing123doesn't also show1234.▸marker as the profile picker, and workspaces without a name render as their ID. The label now says(search by name or ID).termtest.Runso command-level prompts can use the same terminal harness as thecmdioprompt tests.Test plan
./task checks,./task lint-q,./task fmt-q, and thecmd/auth/loginacceptance tests.ug configure.This pull request and its description were written by Isaac.