Repository navigation
Conversation
NewPattern builds a pattern from parts like NewPath does for paths, so callers don't nest the single-step constructors or parse pattern strings. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 6674d4b
Top 6 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
structpath.NewPattern(prev, parts...), the pattern counterpart ofNewPath: strings are keys, ints are indices, andstructpath.AnyKey/structpath.AnyIndexappend.*/[*]wildcards.Why
The upcoming libs/dyn removal (#6954) builds patterns in many places. Without this, callers either nest single-step constructors or format and parse pattern strings, which breaks on user keys containing path syntax. Wildcards are sentinels rather than
"*"strings so a user key named*can't become a wildcard.Tests
Unit test in
libs/structs/structpath.This pull request and its description were written by Isaac.