Repository navigation
Conversation
- Enable nolintlint: normalize `// nolint:` directives and remove ones that no longer suppress anything. - Enable wastedassign and fix the four dead assignments it reports. - Drop revive's use-waitgroup-go (duplicates modernize waitgroupgo) and the `legacy` and `common-false-positives` exclusion presets, which exclude nothing in this repo. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 10aa5af
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
nolintlint. It normalizes// nolint:to//nolint:and removes directives that no longer suppress anything, for examplerecvcheckones now covered by the exclusions added in Bump Go to 1.27.2 and golangci-lint to v2.14.0 #7052.wastedassignand fix its 4 findings.use-waitgroup-go, which duplicates modernizewaitgroupgo; both fire on the same code.legacyandcommon-false-positivesexclusion presets, which exclude nothing in this repo.Why
Follow-up to #7052: trim lint config that is redundant after the golangci-lint v2.14 upgrade, and stop stale
//nolintdirectives from accumulating.Tests
./task lintreports 0 issues on the root and tools modules;go testpasses on all changed packages;./task checkspasses.This pull request and its description were written by Isaac.