Repository navigation
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
The default pointed at resources.jobs.*.task[*], which is not a field, so dbt tasks without a schema never got "default". Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: f0bdea2
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix the default for
dbt_task.schema: it pointed atresources.jobs.*.task[*], which is not a field, so dbt tasks (also insidefor_each_task) without a schema never got"default". It now matchestasks[*], as the Terraform provider does.Why
Found while reviewing the defaults table; the intended default was never applied.
Tests
New
acceptance/bundle/validate/dbt_task_schema_default(first commit records the old behaviour, second shows the fix).paths/nominalandresources/jobs/task-sourcegoldens gain"schema": "default".This pull request and its description were written by Isaac.