Repository navigation
Allow managed storage roots for DMS acceptance catalogs - #7106
Draft
shreyas-goenka wants to merge 1 commit into
Draft
shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
Collaborator
Integration test reportCommit: 35d1457
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Allow DMS acceptance tests to create temporary catalogs in metastores without a default storage root. Setting
TEST_UC_MANAGED_STORAGE_ROOTsupplies--storage-rootfor each catalog, using a separate subdirectory named after the temporary catalog.Why
The catalog recreation tests currently rely on a metastore storage root. An explicit catalog location lets the same tests run in workspaces configured with catalog-level managed storage.
Tests
Ran prerequisites and all four affected acceptance cases (
declined-deploy,successful-recreate,failed-recreate, andoperation-upload-fails-once) against the local fake server, both with the variable unset and with an S3 root ending in/. All eight case executions passed, and the catalog responses confirmed the normalized storage paths. Golden outputs were unchanged. Bash syntax and whitespace checks passed.