Repository navigation
Use stdlib uuid package instead of github.com/google/uuid - #7121
Merged
Merged
Conversation
Go 1.27 adds a uuid package to the standard library. Its New, Parse, String and text/JSON encoding behave the same as google/uuid for the forms the CLI produces and accepts, so existing deployment state and lock files decode unchanged. Parse is stricter than google/uuid: it rejects an upper- or mixed-case "urn:uuid:" prefix and any 38-character form not wrapped in braces (google/uuid accepts e.g. "(...)" or "[...]"). Error text also differs. google/uuid remains an indirect dependency via the SDK and others. Co-authored-by: Isaac <no-reply@databricks.com>
It is no longer a direct dependency. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
marked this pull request as ready for review
October 20, 2026 11:18
pietern
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
October 20, 2026 11:18
pietern
enabled auto-merge
October 20, 2026 11:18
Collaborator
Integration test reportCommit: 8865554
Top 3 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Oct 20, 2026
denik
reviewed
Oct 20, 2026
| github.com/godbus/dbus/v5 v5.2.2 // indirect | ||
| github.com/google/go-querystring v1.2.0 // indirect | ||
| github.com/google/s2a-go v0.1.9 // indirect | ||
| github.com/google/uuid v1.6.0 // indirect |
Contributor
There was a problem hiding this comment.
Can we also update databricks-sdk-go? or does that need to support previous golang versions as well.
Contributor
Author
There was a problem hiding this comment.
Yes, up to EOL. And there's also other deps that still pull it in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace
github.com/google/uuidwith theuuidpackage added to the standard library in Go 1.27.github.com/google/uuidremains an indirect dependency.uuid.Newbehaves the same: both read 16 bytes fromcrypto/randand set the v4 version and variant bits (the CLI never used google/uuid'sSetRandorEnableRandPool). Text and JSON encoding are identical, so existing deployment state and lock files decode unchanged.Parseis stricter: it rejects 38-character forms not wrapped in{…}(google/uuid ignores the first and last character) and a non-lowercaseurn:uuid:prefix.This pull request and its description were written by Isaac.