Repository navigation
Retry more transient errors on reads, lock release and deployment-service calls - #7129
Merged
Merged
Conversation
…vice calls Retry the idempotent calls that failed on transient backend errors in an integration run: deploy lock stat/read/delete, state file reads, remote reads and waits after create/update, and the deployment-service get, list, update and delete calls. Reads also retry "unexpected EOF" transport errors. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
marked this pull request as ready for review
October 20, 2026 13:46
denik
enabled auto-merge
October 20, 2026 13:53
Collaborator
Integration test reportCommit: f98fd07
Top 3 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Retry idempotent calls that were not retried before: deploy lock stat/read/delete, state file reads, remote reads and waits after create/update in the direct engine, and the deployment-service get, list, update and delete calls. Reads also retry
unexpected EOFtransport errors.Why
A cloud integration run (https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/39339632441) failed 8 scenarios on the first attempt with transient 500/504s. A failed lock release left a stale lock, and a
clusters/getunexpected EOFfailed a deploy. Non-idempotent creates (vector search POST,CreateDeployment,CreateVersion) are intentionally not retried.Tests
Unit tests for
IsTransientReadand the retrying filer.This pull request and its description were written by Isaac.