Fix blocking security scan findings on main - #1663
Conversation
…re5) Resolves OSV-Scanner findings and issue #1584: - jackson-databind/core/annotations 2.18.8 -> 2.18.9 (CVE-2026-54515, CVE-2026-59889, GHSA-mhm7-754m-9p8w) - lz4-java 1.10.1 -> 1.11.1 (CVE-2026-59949) - netty-buffer/netty-common 4.2.13.Final -> 4.2.15.Final (#1584) - httpcore5 5.3.6 -> 5.4.3 and pin transitive httpcore5-h2 to 5.4.3 via dependencyManagement (CVE-2026-54399, CVE-2026-54428; #1584). httpclient5 stays 5.5.2, which is compatible with the httpcore5 5.4.x branch. Verified: clean build embeds the fixed versions in the uber jar; OSV-Scanner reports zero findings; integration tests pass (SQL_EXEC 241, THRIFT_SERVER 189, 0 failures/errors). Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
There was a problem hiding this comment.
Verdict: 1 Low
Clean, consistent security dependency bump — httpcore5 5.4.3 (+ new httpcore5-h2 pin), Jackson 2.18.9, lz4-java 1.11.1, Netty 4.2.15.Final — with matching NEXT_CHANGELOG entries. Version properties are consistent and the httpcore5-h2 pin correctly lives in the parent dependencyManagement that both jdbc-core and the uber assembly inherit. One low-severity note: verify httpclient5 5.5.2 runtime compatibility with the forced httpcore5 5.4.3, since the test plan skipped tests.
Use HttpClient 5.6.3 so its supported HttpCore 5.4.3 dependency set resolves naturally, while retaining the security fixes and simplifying the changelog. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
State explicitly that the bundled dependency upgrades address security findings. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
There was a problem hiding this comment.
Verdict: 1 Medium
Dependency-bump PR to clear security-scan findings. One medium concern: the PR description claims to "pin httpcore5-h2," but no such pin exists in the diff or poms — it's only pulled transitively via httpclient5, so the CVE fix isn't enforced and it may skew from the explicitly-pinned httpcore5 5.4.3. The changelog entry and other version bumps look fine.
Other findings
- 🟡 Medium — The PR description says it will "pin
httpcore5-h2" to clear the blocking CVSS 7.5 finding, but there is no such pin anywhere in the diff or the poms —httpcore5-h2is declared neither as a direct dependency nor in<dependencyManagement>(grep finds it only in the historicalCHANGELOG.md). Two consequences worth confirming before relying on this to close the finding:
-
The CVE fix for
httpcore5-h2is not guaranteed.httpcore5-h2is pulled in only transitively viahttpclient5(async-httpclient.version= 5.6.3). Its resolved version is whatever that transitive edge declares — the explicithttpcore5pin (5.4.3) governs a different artifact and does not constrainhttpcore5-h2. If the security finding is againsthttpcore5-h2specifically, it is only resolved if httpclient5 5.6.3 happens to bring a patchedhttpcore5-h2; it is not enforced here. -
Potential version skew between
httpcore5andhttpcore5-h2. These two artifacts are released in lockstep and share internal APIs, so they must resolve to the same version. Forcinghttpcore5to 5.4.3 whilehttpcore5-h2floats transitively (potentially to whatever httpclient5 5.6.3 was built against) risks a mismatch that can surface as runtime linkage errors (NoSuchMethodError/NoClassDefFoundError) on the HTTP/2 path.
Recommend explicitly pinning httpcore5-h2 to ${httpcore5.version} (as a direct dependency or in <dependencyManagement>) to both enforce the CVE fix and keep it aligned with httpcore5. Please also confirm the resolved uber-JAR actually contains httpcore5-h2 5.4.3 (the test plan only mentions verifying httpcore5 and httpcore5-h2 5.4.3 — worth double-checking that claim given no pin exists).
|
JDBC integration tests triggered ( |
|
Addressing the latest reviewer-bot concern: Verified in this branch:
Official dependency report: https://hc.apache.org/httpcomponents-client-5.6.x/5.6.3/httpclient5/dependencies.html |
Summary
httpcore5andhttpcore5-h2to patched version 5.4.3NEXT_CHANGELOG.mdCloses #1584.
Test plan
mvn clean package -Dmaven.test.skip=true -Ddependency-check.skip=true -Bhttpclient5:5.6.3,httpcore5:5.4.3, andhttpcore5-h2:5.4.3Telemetry Errors