Avoid false unsupported-operation telemetry for nested timestamps - #1667
Draft
prathamesh-db wants to merge 1 commit into
Draft
Avoid false unsupported-operation telemetry for nested timestamps#1667prathamesh-db wants to merge 1 commit into
prathamesh-db wants to merge 1 commit into
Conversation
Signed-off-by: Prathamesh Baviskar <prathamesh.baviskar@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parses Arrow's epoch-microsecond representation for nested
TIMESTAMPandTIMESTAMP_NTZvalues before trying the formatted-string converter. Successful numeric values therefore no longer construct and export a falseUNSUPPORTED_OPERATIONerror. Formatted timestamp strings and returned timestamp values are unchanged.Testing
The regression test covers both timestamp types, a pre-1970 value, microsecond precision, and verifies that successful numeric parsing never initializes the telemetry client.
mvn spotless:apply: passedmaindependencies were unavailable because Maven Central DNS resolution failed locally. CI remains the current test gate.Telemetry Errors
UNSUPPORTED_OPERATIONemission; it adds no error code or numeric value.Additional Notes to the Reviewer
Review focus: numeric-first fallback behavior and the no-telemetry regression assertion.
NO_CHANGELOG=true