Skip to content

chore(kernel): bump KERNEL_REV for getTypeInfo parity - #512

Merged
cathleeny merged 2 commits into
mainfrom
PECOBLR-4166
Aug 25, 2026
Merged

chore(kernel): bump KERNEL_REV for getTypeInfo parity#512
cathleeny merged 2 commits into
mainfrom
PECOBLR-4166

Conversation

@cathleeny

@cathleeny cathleeny commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • bump KERNEL_REV to the merged databricks-sql-kernel#291 commit so source-built native bindings include the getTypeInfo() parity fix
  • document that source-build behavior in the changelog
  • keep the checked-in loader and npm platform dependencies aligned at 0.2.0, the latest currently published native package version

Release note

This pin makes the fix available to source builds. Customer-facing npm installs still resolve the 0.2.0 platform packages, which do not contain Kernel #291. Once a native package containing that change is published, a follow-up must update all eight optional dependencies, package-lock.json, and the generated loader together.

Validation

  • built the native binding locally from the exact pinned Kernel SHA
  • loaded that locally built binding and verified version() returns 0.2.1
  • npm run build
  • npm test -- tests/unit/kernel/execution.test.ts (68 passing)
  • focused Node comparator run matched Thrift and SEA for list_type_info

Signed-off-by: Cathleen Yan <cathleen.yan@databricks.com>
@cathleeny
cathleeny deployed to azure-prod August 25, 2026 22:21 — with GitHub Actions Active
@cathleeny
cathleeny deployed to azure-prod August 25, 2026 22:21 — with GitHub Actions Active
@cathleeny
cathleeny deployed to azure-prod August 25, 2026 22:21 — with GitHub Actions Active
@cathleeny
cathleeny deployed to azure-prod August 25, 2026 22:21 — with GitHub Actions Active
@cathleeny
cathleeny marked this pull request as ready for review August 25, 2026 22:24

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: 1 High

Needs a fix before merge: the loader was regenerated to require kernel binding 0.2.1, but package.json optionalDependencies (and package-lock.json) still pin the native packages to 0.2.0. This means the advertised getTypeInfo() parity fix won't actually be installed, and enabling NAPI_RS_ENFORCE_VERSION_CHECK will throw a version-mismatch error. The CHANGELOG and KERNEL_REV changes themselves look correct.

Other findings

  • 🟠 High — The regenerated loader now enforces 0.2.1 for every native binding (e.g. if (bindingPackageVersion !== '0.2.1' && process.env.NAPI_RS_ENFORCE_VERSION_CHECK ...)), but optionalDependencies here still pin all @databricks/databricks-sql-kernel-* packages to 0.2.0. package-lock.json likewise still resolves them to 0.2.0.

Two consequences:

  1. The parity fix does not ship. The getTypeInfo() fix documented in this PR lives in the 0.2.1 native package, but a fresh npm install will still fetch and load 0.2.0 — so the behavior this PR advertises won't actually be present for consumers.
  2. Hard failure when the version check is enabled. With NAPI_RS_ENFORCE_VERSION_CHECK set to a non-0 value, the loader will throw Native binding package version mismatch, expected 0.2.1 but got 0.2.0 because the installed optional dep is 0.2.0.

The optionalDependencies pins (all 8 entries) and the corresponding package-lock.json entries should be bumped to 0.2.1 to match the loader and KERNEL_REV.

Signed-off-by: Cathleen Yan <cathleen.yan@databricks.com>

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@cathleeny
cathleeny added this pull request to the merge queue Aug 25, 2026
@cathleeny
cathleeny removed this pull request from the merge queue due to a manual request Aug 25, 2026
@cathleeny
cathleeny added this pull request to the merge queue Aug 25, 2026
Merged via the queue into main with commit d5175c4 Aug 25, 2026
24 of 25 checks passed
@cathleeny
cathleeny deleted the PECOBLR-4166 branch August 25, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant