chore(cli): rimuovi comandi morti cmd_batch e shim sql_dry_run - #459
Merged
Conversation
Cleanup audit: due file senza consumer reali. - cmd_batch.py: comando 'toolkit batch' deprecato da tempo, sostituito da 'toolkit run --batch' (cmd_run.py). Unico riferimento: registrazione in app.py. - sql_dry_run.py: shim di reindirizzamento verso core.sql_validation; nessun import (cmd_run usa sql_validation direttamente). Rimossa registrazione register_batch da app.py. Nessun test dipendeva dai file rimossi (1324 verdi invariati), ruff pulito, zero riferimenti orfani.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tipo
cleanup reale — rimozione di 2 file morti dalla CLI, emersi da un audit della superficie toolkit.
Problema reale
Audit del toolkit: due moduli CLI senza consumer reali.
toolkit/cli/cmd_batch.py— comandotoolkit batch, deprecato (emetteDeprecationWarning), sostituito datoolkit run --batch(già implementato incmd_run.py). Unico riferimento nel codebase: la registrazione inapp.py.toolkit/cli/sql_dry_run.py— shim di reindirizzamento (import *dacore.sql_validation+DeprecationWarning). Nessun import nel codebase:cmd_run.pyimportavalidate_sql_dry_rundirettamente dacore.sql_validation.Codice rimosso
toolkit/cli/cmd_batch.pyrun --batchtoolkit/cli/sql_dry_run.pytoolkit/cli/app.py(modificato)register_batchVerifica
toolkit batchnon esiste più (errore);toolkit run --batchintatto e funzionantetest_sql_dry_run.pytestacore.sql_validation, non lo shim)cmd_batch/cli.sql_dry_runRischio residuo
Nessuno — i 2 file erano già unreachable dal flusso reale (deprecati + nessun import).
Follow-up
Nessuno obbligatorio. Valutazione annotata (non bloccante): il flag
routedditoolkit_probe_urlè una duplicazione di superficie (routed = superset del classico) ma con test dedicati e valore del probe snello nel CLI scout — refactor possibile in futuro, cambierebbe contratto tool.