Add ingestion_input_path to top level tf outputs#72
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a new Terraform output ingestion_input_path to the infra/dcp/outputs.tf file. The reviewer suggests making this output conditional on the enable_ingestion variable to ensure consistency and prevent misleading information when the feature is disabled, along with a recommendation to update the description and document stack dependencies.
| output "ingestion_input_path" { | ||
| description = "Path within the bucket where raw files should be uploaded" | ||
| value = var.ingestion_input_path | ||
| } |
There was a problem hiding this comment.
To maintain consistency with other outputs in this project and avoid providing misleading information when the ingestion feature is disabled, this output should be conditional on var.enable_ingestion. Additionally, the description should be updated to match the one used in the variable definition for consistency. Since this output relies on the ingestion_bucket_url from another stack, ensure this dependency is explicitly documented in the Terraform variable descriptions or comments to prevent confusion regarding its optionality, as per repository rules.
output "ingestion_input_path" {
description = "Path within the bucket where raw files are uploaded"
value = var.enable_ingestion ? var.ingestion_input_path : null
}
References
- When an infrastructure component or workflow step has a mandatory dependency on another stack, ensure this requirement is explicitly documented in Terraform variable descriptions or comments to prevent confusion regarding its optionality.
No description provided.