This change added the last_update_timestamp to the integration test to reflect the schema change that includes the new field#514
Merged
shixiao-coder merged 2 commits intoMay 27, 2026
Conversation
…o reflect the schema change that includes the new field
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a last_update_timestamp column to the Node table in the Spanner test schema. The reviewer noted that this column is missing from the main production schema file, which could lead to schema drift, and requested clarification on how schema changes are applied to existing databases.
Up to standards ✅🟢 Issues
|
gmechali
approved these changes
May 27, 2026
Contributor
gmechali
left a comment
gmechali
left a comment
There was a problem hiding this comment.
thanks Xiao! it would defintely be very nice to get those merged.
shixiao-coder
deleted the
fix-integration-test-failure-for-missing-timestamp
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test failed in https://pantheon.corp.google.com/cloud-build/builds;region=global/4ff57037-7aae-4166-ac2d-914809747f75;step=1?e=13803378&mods=-monitoring_api_staging&project=datcom-ci, it dues to the test schema.sql not updated for the integration test.
This PR updated this test schema.sql