Skip to content

Automated Integration Test Goldens Update from CI#6321

Closed
datacommons-robot-author wants to merge 1 commit into
masterfrom
nl-golden-update-50b41c5c-a633-4dcc-92c3-a752860600c6
Closed

Automated Integration Test Goldens Update from CI#6321
datacommons-robot-author wants to merge 1 commit into
masterfrom
nl-golden-update-50b41c5c-a633-4dcc-92c3-a752860600c6

Conversation

@datacommons-robot-author
Copy link
Copy Markdown
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@datacommons-robot-author datacommons-robot-author requested review from a team and beets and removed request for a team May 28, 2026 00:32
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains an automated update to the integration test golden files, specifically modifying the chart configuration for the states with highest PhDs detection API context. These changes ensure that the test expectations remain aligned with the current system output.

Highlights

  • Golden File Update: Updated the chart configuration for the 'stateswithhighestphds' integration test to include a new classification criteria.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration test golden file chart_config.json by adding a classification with a quantity threshold. The reviewer pointed out that the threshold value 2.2250738585072014e-308 is the minimum representable positive float, which suggests an underlying bug in the quantity detection or parsing logic. It is recommended to investigate the detection code rather than manually updating this automatically generated golden file.

"idx": 0,
"qval": {
"cmp": "GE",
"val": 2.2250738585072014e-308
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The value 2.2250738585072014e-308 corresponds to sys.float_info.min (the minimum representable positive normalized float). Its appearance here as a quantity threshold for 'states with highest phds' suggests an underlying bug in the quantity detection or parsing logic (such as an uninitialized default float value or a parsing error). Please investigate the detection/parsing code rather than manually editing this golden file, as golden files are automatically generated.

References
  1. Do not manually round floating-point values in golden files or test data files that are automatically generated by scripts, as these files should only be updated via the automation tools.

@clincoln8 clincoln8 closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants