Fix first-run onboarding classification before startup - #634
Merged
yaojin3616 merged 1 commit intoOct 1, 2026
Merged
Conversation
scpli
pushed a commit
to scpli/dsh-desktop
that referenced
this pull request
Oct 2, 2026
…#634/dataelement#635 - src/main/index.ts: keep both desktop-startup-install and workbench-market-recovery imports. - workbenches client.js: keep sortMarketEntries (main) and FailureHint (dataelement#633); combine local removal status (dataelement#635) with stale-record removal (dataelement#633) so the uninstall button honours both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
首次安装分类函数已存在，但应用启动从未调用。Onboarding 宿主读取不到
.desktop-install-state.json，于是把所有安装视为不符合弹窗条件；即使清空用户数据也不会显示。DesktopService 初始化和 bootstrap 又会创建旧安装痕迹，分类必须发生在它们之前。修复
在单实例主启动路径中、DesktopService 初始化之前写入首次安装分类。保持开发构建和已有安装不弹窗的既有规则，并增加测试验证标记写入顺序。
验证
npm run build：通过git diff --check：通过desktop-onboarding.test.ts对已安装 Harness client.js 的字符串断言失败；npm run typecheck在test/session-delete-remote.test.ts的remote.delete类型检查有 3 处错误，均非本 PR 修改文件。需要在 CI 中确认/处理基线问题。发布注意
此 PR 只修复源码。已分发的安装包不会随源码更新；需要新的构建并用干净的正式版用户数据目录验证弹窗。