Skip to content

fix(workbenches): preserve host stylesheet ownership - #636

Merged
yaojin3616 merged 1 commit into
dataelement:mainfrom
cinderzhan:codex/fix-workbench-host-style-ownership
Oct 1, 2026
Merged

yaojin3616 merged 1 commit into
dataelement:mainfrom
cinderzhan:codex/fix-workbench-host-style-ownership

Conversation

@cinderzhan

Copy link
Copy Markdown
Collaborator

Summary

  • Mark the Desktop workbench stylesheet with its module owner (data-plugin) when creating or reusing it.
  • Prevent the client module loader from claiming this stylesheet for another plugin and removing it during reload.
  • Cover ownership correction and stylesheet recreation in the lifecycle test.

Verification

  • npx vitest run test/workbench-client.test.mjs (136 passed)
  • npm run typecheck
  • npm run build
  • git diff --check origin/main codex/fix-workbench-host-style-ownership

The change is scoped to the Desktop host stylesheet; individual workbench style handling is covered separately.

@yaojin3616
yaojin3616 merged commit 46a02cd into dataelement:main Oct 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants