Skip to content

Scope workspace removal to the active workbench - #639

Merged
yaojin3616 merged 1 commit into
dataelement:mainfrom
cinderzhan:codex/workbench-scoped-workspace-delete
Oct 1, 2026
Merged

yaojin3616 merged 1 commit into
dataelement:mainfrom
cinderzhan:codex/workbench-scoped-workspace-delete

Conversation

@cinderzhan

Copy link
Copy Markdown
Collaborator

Summary

  • Keep Host workspace registration intact when a workspace is removed inside a workbench. The removal now persists a hidden workspace ID for that workbench only; sessions in that workbench become ungrouped, while another workbench keeps the same workspace and its sessions grouped.
  • Add a narrow UI workspace filter and delete handler seam to the Harness 0.2.0-rc.2 patch. Native conversation mode continues to use the existing global delete behavior. A failed scoped delete never falls back to global deletion.
  • Exclude hidden workspaces from default/new-session choices, restore them on explicit re-add of the same folder, and migrate legacy workbench IDs and saved state safely.

Verification

  • Clean npm ci replayed the equivalent 0.1.7-rc.2 patch in the local checkout.
  • npx vitest run test/workbench-state.test.mjs test/workbench-client.test.mjs test/workbench-navigation.test.mjs (193 passed)
  • npm test (1542 passed), npm run typecheck, npm run build, git diff --check
  • The 0.2.0-rc.2 patch was applied to a pristine upstream package and the result was compared byte-for-byte with the intended files; node --check passed.

The local checkout uses Harness 0.1.7-rc.2; this PR targets main on 0.2.0-rc.2. Windows packaged UI validation remains for CI/QA.

Keep shared workspace registration and sessions when removing a workspace
from one workbench. Persist per-workbench visibility, restore it on
explicit re-add, and expose a narrow upstream UI deletion seam.
@yaojin3616
yaojin3616 merged commit 95a77cc into dataelement:main Oct 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants