fix(mac): terminal posix_spawn ENOENT; run package commands on the Electron Helper and drop bundled Node

[yaojin3616]

Two related macOS runtime fixes, from packaged Harness and package commands running from app.asar.unpacked on the Electron runtime, plus a generation-installer fix found while verifying them.

1. Sidebar terminal: posix_spawn failed: No such file or directory

node-pty starts the shell through spawn-helper. It derives the helper path with replace('app.asar', 'app.asar.unpacked'), so a path that is already unpacked became app.asar.unpacked.unpacked/.../spawn-helper. Since #570, packaged Harness loads dependencies from that physical directory.

• patches/node-pty+1.2.0-beta.15.patch skips paths already followed by .unpacked. 1.2.0-beta.15 is the newest beta; remove the patch once upstream fixes it.
• Windows is unaffected: it has no spawn-helper. A scan of the packaged app found no other dependency that rewrites app.asar paths.

2. One Node runtime on macOS: Electron Helper; bundled Node removed

macOS Harness already ran in an Electron utility process. Profile repair, market baseline, generation installs and the .desktop-bin node/pnpm shims still used a bundled standalone Node 24.9.0, so two Node runtimes installed into one Profile. The main-process shim writer and the Harness-side shim writer also disagreed with each other.

• bundledNodePath() → electronNodeExecutable(): the app's Helper on macOS, the main executable elsewhere. Package commands and shims always set ELECTRON_RUN_AS_NODE=1. The generation installer now injects it under any Electron runtime, not only on Windows. Without it the Helper boots a full GUI app; during testing this showed up as a bogus "gpu-crash" report.
• Main-process generation installs (plugin upgrade, legacy migration) now go through packageCommandEnvironment(), which rewrites the shims and puts them on PATH. pnpm adds only its runtime's directory for lifecycle scripts, and the Electron runtime has no node there, so a dependency's node … install script failed with node: command not found. Rewriting the shims also replaces ones an upgraded install left pointing at the removed Node.
• Linux development launches Harness through Electron Node mode as well.
• Removed the node dependency (lockfile: node, node-bin-setup) and the win.files exclusion for it. verify-target and the afterPack runtime check use the Electron executable / Helper instead. Docs updated.

3. Generation installer hoisted an @deepseek-ai/* plugin out of its own generation

The host-singleton patterns cover the whole @deepseek-ai scope. Installing a plugin from that scope (seen with @deepseek-ai/dsh-subagent-claude-code during legacy migration) therefore removed the plugin itself from the generation. Migration then failed with ENOENT on its package.json and rolled the Profile back; peer validation would also have reported it as a private host singleton. The generation walk used by hoisting and by validation now exempts only the top-level plugin package. Nested copies of the same name and every other host package are still removed. Regression: test/generation-installer.test.ts (fails without the fix).

Checks

• Clean npm ci (node-pty patch applied, no node_modules/node); npm test 179 files / 1600 tests; npm run typecheck; git diff --check; node scripts/verify-target.mjs darwin arm64 (Electron 43.0.0 / Node 24.17.0 loads the Harness native loader)
• Regression tests that fail without the fix:
  • node-pty loaded from app.asar.unpacked spawns a PTY
  • package commands plus both shims on the real Electron Helper, with no ELECTRON_RUN_AS_NODE in the base env (hangs without the fix)
  • stale shims naming a removed Node are rewritten
  • a dependency postinstall that runs node succeeds with a Node-free base PATH
• Unsigned package:dev:dir (arm64):
  • no node_modules/node; app.asar.unpacked 661 MB → 549 MB; the afterPack check ran on the Helper
  • node-pty from app.asar.unpacked starts a login shell
  • the packaged installer, driven from an Electron main process with the Helper, published a real generation; with the old win32-only condition it failed
• Upgrade simulation: packaged build on a temp userData seeded with shims naming the removed bundled Node.
  • The shims were rewritten to the Helper.
  • The main-process dsh CLI and pnpm ran.
  • A migrated plugin generation installed via the Helper.
  • Two failures unrelated to the runtime were observed. The installer hoisting an @deepseek-ai/* plugin out of its own generation is fixed in section 3. dshmarket@1.65.1 declaring peers that do not include dsh 0.2.0-rc.2 needs a market release and is not addressed here.

Not verified: signed/notarized build, x64 mac, Windows packaging and installer (CI), market install and upgrade through the real UI.

🤖 Generated with Claude Code