Skip to content

fix(#1438): preserve json flag for MariaDB longtext-aliased columns #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimitri-yatsenko merged 1 commit into from
Apr 30, 2026
+10 −2
Merged

fix(#1438): preserve json flag for MariaDB longtext-aliased columns #1443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/datajoint/heading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,8 +508,16 @@ def _init_from_database(self) -> None:
if category == "UUID":
attr["uuid"] = True
elif category in CORE_TYPE_NAMES:
# Core type alias - already resolved in DB
pass
# Core type alias - already resolved in DB.
# MariaDB-specific recovery: MariaDB stores `json` columns
# as `longtext` and reports them back that way through
# information_schema, so the DB-type-based detection above
# leaves attr["json"] False. The :json: comment marker
# survives this aliasing, so we recover the json flag here
# from the original declared type. No-op on MySQL/PostgreSQL
# (attr["json"] is already True from the regex match above).
if category == "JSON":
attr["json"] = True

# Check primary key constraints
if attr["in_key"] and (attr["is_blob"] or attr["json"]):
Expand Down
Loading