Repository navigation
deps: pin plotly.rs fork to plotly/plotly.rs#442 head (full plotly.js 3.7 traces) - #4838
Merged
Merged
Conversation
… 3.7 traces) Moves the dathere/plotly pin from a21da1f to 55555b2, the final commit of the 0.15.0 release branch. The new commits add the remaining 13 plotly.js 3.7 trace types; the only breaking change (mesh3d::LightPosition) is not used by qsv. Only plotly, plotly_derive and plotly_static move in Cargo.lock. Verified: viz unit + integration suites pass, qsvmcp (viz_static) builds, and a full gallery regen differs only in per-run timestamps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This was referenced Oct 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
dathere/plotlypin froma21da1fto55555b2, the final commit of the plotly.rs 0.15.0 release branch (plotly/plotly.rs#442). The new commits add the remaining 13 plotly.js 3.7 trace types (Parcoords, BarPolar, FunnelArea, ScatterTernary, Histogram2dContour, …). Follow-up PRs will use some of them inviz.mesh3d::LightPosition(x/y/z fromVec<f64>tof64), isn't used by qsv.viz.rsis the only plotly consumer.Cargo.lock: onlyplotly,plotly_deriveandplotly_staticmove.Verification
cargo t viz -F all_features: 482 unit + 637 integration tests pass (16 ignored as on master)cargo build --bin qsvmcp -F qsvmcp(includesviz_static) buildscargo clippy -F all_features: no new warningsgen_gallery.pyregen:gallery.htmlis byte-identical, and the dashboards differ only in per-runCompiled:/ statsdate_generatedstamps, so nothing was committed.🤖 Generated with Claude Code