Require interactions for recorded observations#4
Merged
Conversation
daugaard
changed the title
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interactionas the required recording surface for custom integrations.interaction_idon every SDK ingestion payload.Breaking change
This is a breaking SDK API and ingestion payload change: direct recording methods were removed from
Session, and users must record throughsession.interaction(interaction_id=...). That is acceptable because SessionBat has no production data yet, so we do not need legacy compatibility.Coordination
This is the SDK-side PR for #3. The app PR in
daugaard/sessionbat-appshould merge first so the server accepts requiredinteraction_idpayloads before this SDK change is released or promoted.Tests
uv run pytestuv run ruff check .uv run ruff format --check .