Repository navigation
Let slow query alert happen before paged output - #2338
Merged
Merged
Conversation
beep_after_seconds sets a threshold time for the user to receive an alarm on the completion of a slow query. The idea behind the feature is that the user may have tabbed away from mycli while waiting and would like an alert to tab back. But the implementation was sending the alarm _after_ the output, meaning that if the output was long enough to be paged, the beep would not be heard on query-completion, but rather on pager-exit, defeating the purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
beep_after_secondssets a threshold time for the user to receive an alarm on the completion of a slow query. The idea behind the feature is that the user may have tabbed away from mycli while waiting and would like an alert to tab back.But the implementation was sending the alarm after the output, meaning that if the output was long enough to be paged, the beep would not be heard on query-completion, but rather on pager-exit, defeating the purpose.
Checklist
changelog.mdfile.mycli/AUTHORS.txtfile (or it's already there).