Repository navigation
Allow comma-containing init-commands in ~/.myclirc - #2341
Merged
Merged
Conversation
Generalize FavoriteQueryPreservingConfigObj's _parse() to cover all config file stanzas with SQL values: * favorite_queries * init-commands * alias_dsn.init-commands And use a new class name SQLValuePreservingConfigObj. Incidentally update the known_bugs.md with an explanation of the limitation on saving favorite_queries with internal triplequotes. Though the same issue exists on read of unquoted init-commands, it is harder to explain, and left out of the known_bugs.md entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generalize
FavoriteQueryPreservingConfigObj's_parse()to cover all config file stanzas with SQL values:favorite_queriesinit-commandsalias_dsn.init-commandsAnd use a new class name
SQLValuePreservingConfigObj.Incidentally update the
known_bugs.mdwith an explanation of the limitation on saving favorite_queries with internal triplequotes. Though the same issue exists on read of unquoted init-commands, it is harder to explain, and left out of theknown_bugs.mdentry.xref #2340
Checklist
changelog.mdfile.mycli/AUTHORS.txtfile (or it's already there).