Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found 1 new issue in 1 file · 1 warning · score 86 / 100 (Great) · 8 fixed · vs Reviewed by React Doctor for commit |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const promptsResponse = await API.sessions.getPrompts(activeSession.id); | ||
| if (promptsResponse.success && promptsResponse.data?.length > 0) { | ||
| return promptsResponse.data.map((p: PromptMarker) => p.prompt_text).filter(Boolean).join('\n\n'); | ||
| return promptsResponse.data.map((p: { prompt_text: string }) => p.prompt_text).filter(Boolean).join('\n\n'); |
There was a problem hiding this comment.
React Doctor · react-doctor/js-flatmap-filter (warning)
This loops over your list twice because .map().filter(Boolean) makes two passes, so use .flatMap() to change & drop items in one pass
Fix → Use .flatMap(item => condition ? [value] : []) to change and drop items in one pass, instead of building a throwaway array in between
1 participant
Session navigation still ran the retired conversation/output view subsystem: unused loading/retry state, a never-created script terminal, and DOM event relays. It also subscribed to every panel-store update and recorded navigation history that nothing read. Overlapping preference saves could restore an old snapshot over a newer edit.
This PR removes that obsolete renderer machinery and its unused hydration/history tests, keeps the consumed git/archive actions, and selects panel/layout state for the displayed session. Backend histories, prompt-based commit messages, terminal output persistence, and exports keep their existing paths.
Preference writes now save full snapshots in edit order. Older failures leave newer edits visible, latest failures restore the last confirmed snapshot, and load ownership prevents late reads from replacing edits or clearing another read's loading state. No dependencies are added or updated.
Closes #616
Closes #617
Closes #619
Validation: