refactor: share frontend test setup and avoid duplicate CI - #134
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
PASS Independent shipping verification for PR134 ( Base: Evidence:
Verdict: PASS. I found no blockers for merge. |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Four App test suites repeated the same desktop API mocks, reset behavior, and deferred-promise helper. An open pull request also triggered the full check matrix twice, once for its branch push and once for the pull request.
Scope
mainandv*tags.Blast Radius
Application behavior and release checks are preserved. Test mock defaults are unchanged. The production frontend bundle is byte-for-byte identical to the base commit's bundle.
Verification
git diff --checkpass.84b6c1b; all files are identical.This is the first unit of the Echo complexity reduction. Recording and settings contract changes will be reviewed separately.