Allow PHP 8.4#8
Merged
Merged
Conversation
Raise the upper bound in the plugin manifest from <8.4 to <8.5 so that installations on PHP 8.4 are no longer blocked by the plugin manager. Matomo core supports PHP 8.4 as of late 2024 (matomo-org/matomo#22471), and nothing in this plugin's source relies on behaviour that changed in 8.4. Also extend the test matrix to include PHP 8.4 so regressions are caught. Fixes deadda7a#7 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@deadda7a - Mind taking a look at this? Just a version bump. |
Owner
|
Hey, sorry, I was on holiday :) If I find the time I will also finally rewrite this extension, I wrote it very much "yolo", and I think now I know how to integrate it better with Matomo |
Owner
|
Manually reviewed the few changes; They are ok, maybe this is the valid usage of AI in development? idk Should not introduce any breaking changes, will test |
Contributor
Author
|
@deadda7a - thanks for the merge. Would you be able to cut a 3.0.3 release? |
Owner
|
Yep, I'm just testing 8.5 too "quickly". Should be done today, or as soon as the database imported on my laptop... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin.jsonfrom<8.4to<8.5so the plugin manager no longer refuses to install on PHP 8.4. Matomo core supports PHP 8.4 (Ensure Matomo is functional with PHP 8.4 matomo-org/matomo#22471, closed Oct 2024) and the plugin source uses nothing that changed in 8.4.8.4to the GitHub Actions test matrix (and the regeneration command comment) so future regressions on 8.4 are caught.Fixes #7.
Test plan
7.4,8.1,8.2,8.3, and the newly added8.4.🤖 Generated with Claude Code