Skip to content

Scrum 109 indicate currently active view on the sidebar#41

Open
avocado-rice wants to merge 5 commits into
masterfrom
SCRUM-109-Indicate-currently-active-view-on-the-sidebar
Open

Scrum 109 indicate currently active view on the sidebar#41
avocado-rice wants to merge 5 commits into
masterfrom
SCRUM-109-Indicate-currently-active-view-on-the-sidebar

Conversation

@avocado-rice

Copy link
Copy Markdown
Contributor

Description

This PR introduces highlighting the currently open page on the left sidebar.

Testing

  • I have covered code introduced by this pull request with tests.
  • I have run all tests with npm run test && npx playwright test and ensured that they pass consistently.

The playwright tests do not pass, can the reviewer check this out, maybe it's because of me using WSL. Thank youuuu

@Mateusz-Dobrzynski Mateusz-Dobrzynski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing tests are passing for me, there must be something wrong with your setup. This PR also isn't covered with any kinds of tests and since the underlying logic is not exactly human-readable, I'd rather have it tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants