chore(deps): remove unused eventsource dependency - #391
Merged
Conversation
The root eventsource dependency has been unused since the initial commit — nothing in the repo imports it. The only real EventSource implementation in use is @modelcontextprotocol/sdk's own pinned eventsource@3.0.7 (unchanged by this removal). Dropping the dead dependency shrinks the published dependency tree and stops dependabot from churning major-version PRs (#385) on a package we never load. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the root
eventsourcedependency, which has been unused since the initial commit — nothing in the repo imports it (the only mentions are comments insrc/cli/sse-command.tsandtools/dev-proxy/dev-proxy.mjs).The actual EventSource implementation exercised by the SSE transport and its tests is
@modelcontextprotocol/sdk's own pinnedeventsource@3.0.7, which is untouched by this change (verified still present in the lockfile).Why remove instead of merging #385
Dependabot's #385 bumps this dep 4.1.1 → 5.0.0, but since nothing loads it, the bump is untestable by CI and the dep would keep generating major-version PRs forever. Removing it shrinks the published dependency tree instead. Closes the loop on #385 (will be closed with a pointer here).
Verification
eventsourcepnpm installregenerated the lockfile; SDK'seventsource@3.0.7remains🤖 Generated with Claude Code