Open
Conversation
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
yaroslavborbat
previously approved these changes
Apr 24, 2026
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore the dedicated
MigrationPendingVMOP reason for the earliest migration states, bind it to0%progress, and treat target scheduling as an active in-progress stage.Technically, the change updates migration lifecycle handling so that:
MigrationPhaseUnsetandMigrationPendingmap tovmopcondition.ReasonMigrationPending;ReasonMigrationPendingkeeps VMOP inPendingphase;ReasonMigrationPendingreports0%progress;MigrationSchedulingmaps toReasonTargetSchedulingwith2%progress;ReasonTargetSchedulingkeeps VMOP inInProgressphase instead ofPending;NotConverging, and failure classification.Unit tests were updated to cover the restored reason, progress mapping, and the new phase/message semantics.
Why do we need it, and what problem does it solve?
After the migration progress refactoring, the earliest migration states started reporting
TargetSchedulingwith2%progress instead of the historicalMigrationPendingstate.This changed the external behavior of VMOP conditions too early: an operation that was still only queued already looked like target scheduling had started. At the same time, once scheduling actually began, VMOP still remained in
Pending, which blurred the difference between a queued operation and an actively executing one.This fix restores the semantic split:
MigrationPending,Pending,0%;TargetScheduling,InProgress,2%.This makes VMOP conditions and VM migration messages closer to the real migration lifecycle and more useful for users and integrations. The internal documentation captures these semantics for future maintainers and reviewers.
What is the expected result?
status.conditions[Completed].reasonisMigrationPending.status.phaseisPendingandstatus.progressis0%.TargetScheduling.status.phasechanges toInProgressandstatus.progresschanges to2%.docs/internal/vmop_migration_lifecycle.mdas the internal reference for reason/progress mapping and failure behavior.Checklist
Changelog entries