Fix: Refactor AMI pjsip reload and improve ami command response handling#62
Open
a2luca wants to merge 2 commits intodect-e:mainfrom
Open
Fix: Refactor AMI pjsip reload and improve ami command response handling#62a2luca wants to merge 2 commits intodect-e:mainfrom
a2luca wants to merge 2 commits intodect-e:mainfrom
Conversation
Refactor trigger function to replace pjsip reload, as it is not available on all versions of asterisk and add response validation.
Fixed the message return from asterisk and only print the error messages, as we don't need the spam success messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #61, the current NixOs asterisk server the pjsip reload alias doesn't work and there is no response handling, so you can't see if anything goes wrong with the reload.
This pr uses "module reload res_pjsip_config_wizard.so" and checks the response for a success message.