feat(cli): connect newly created machines in Scalar - #36
Draft
Shengming Liang (AgentWings) wants to merge 1 commit into
Draft
feat(cli): connect newly created machines in Scalar#36Shengming Liang (AgentWings) wants to merge 1 commit into
Shengming Liang (AgentWings) wants to merge 1 commit into
Conversation
Shengming Liang (AgentWings)
requested review from
Tsion Kergo (tsiongk) and
Windsor Nguyễn (windsornguyen)
August 24, 2026 23:47
Shengming Liang (AgentWings)
force-pushed
the
feat/dcs-317-machines-create-connect
branch
from
August 25, 2026 00:05
8da74ac to
6b839bb
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Shengming Liang (AgentWings)
force-pushed
the
feat/dcs-317-machines-create-connect
branch
from
August 25, 2026 00:06
6b839bb to
377ef12
Compare
Shengming Liang (AgentWings)
changed the base branch from
main
to
codex/eng-743-scalar-cli-auth
August 25, 2026 00:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Note
TL;DR: Scalar's CLI now supports
dedalus machines create --connectas regeneration-safe custom code.Authorship: AI-assisted by Codex, directed and reviewed by Shengming Liang.
Review context: Slack discussion.
Linear Issue
Ref DCS-317
Summary
What:
Adds a handwritten
machines createadapter undersrc/custom. It sends an empty JSON object through Scalar's generated client so the API supplies the default machine shape, then--connectcreates and polls an SSH session and opens the local OpenSSH client with ephemeral credentials and strict host trust.Why:
First-run users should be able to create and enter a machine with one readable command. This keeps the onboarding command stable while Scalar owns SDK generation and release publication.
Important
Lines added MUST be under +500. Use stacked diffs for larger changes. Deletions are always welcome.
Lines added: 499
Test Plan
npm test(124 tests)npm run typecheckSCALAR_BASE_REF=upstream/scalar-next npm run scalar:checknode dist/esm/custom/bin.js machines create --help{}, Bearer auth, and a generated idempotency keymachine_idis passed to the connectorRepro / Showcase
Tests Added
Documentation
Internal (
docs/):External:
Reviewers
Notes for Reviewers
This follows Scalar's custom-code branch model: the change adds separate handwritten files under
src/customand does not editscalar-generatedor the generated SDK. It is temporarily stacked on #35 because that PR establishes the Scalar custom entry point. Once #35 lands, this branch should advance toscalar-next; Scalar then carriesscalar-nextinto its release PR formain.The generated snapshot still calls the operation
machine-lifecycle createand predates the optional machine-shape schema. This adapter provides the desired public command without modifying generated files. Server-side defaults landed in dedalus-labs/dedalus#5343.Changelog
2026-08-24
Feedback received:
Changes made: