Skip to content

feat(doc): 增加文档评论会话安全入口#83

Draft
leohxj wants to merge 5 commits into
deepcoldy:masterfrom
leohxj:feat/doc-comment-sessions
Draft

feat(doc): 增加文档评论会话安全入口#83
leohxj wants to merge 5 commits into
deepcoldy:masterfrom
leohxj:feat/doc-comment-sessions

Conversation

@leohxj

@leohxj leohxj commented May 30, 2026

Copy link
Copy Markdown

What changed

  • Add doc comment session configuration under docComments, including explicit document allowlists, per-document author allowlists, and optional pinned working directories.
  • Add doc session policy helpers for stable document anchors, filesystem-safe temporary workspaces, and talk-only collaborator access.
  • Harden working directory root checks against sibling-prefix and symlink escape cases.
  • Document the new config in README, README.en, and bots.json.example.

Why

Document comments can bring arbitrary collaborators into a bot-visible surface. The first PR establishes the permission and workspace boundary before wiring the live Feishu comment event loop.

Validation

  • pnpm exec vitest run test/working-dir.test.ts test/doc-comment-session.test.ts test/bot-registry.test.ts test/setup-verify-permissions.test.ts passed: 68 tests.
  • pnpm build passed.
  • pnpm test was attempted and still has existing environment-dependent failures: Feishu browser e2e missing FEISHU_TEST_GROUP_URL / MIDSCENE_MODEL_NAME / MIDSCENE_MODEL_API_KEY, CLI/tmux e2e posix_spawnp failed, and an existing bridge-final-output-retry mock missing resolveBrandLabel.

@leohxj leohxj requested a review from deepcoldy as a code owner May 30, 2026 03:18
@deepcoldy

deepcoldy commented May 30, 2026

Copy link
Copy Markdown
Owner

好主意啊👍
CleanShot 2026-05-31 at 01 24 53@2x
@leohxj 要等你把完整功能实现了再Merge么

@leohxj

leohxj commented Jun 1, 2026

Copy link
Copy Markdown
Author

@deepcoldy 哈哈,缺一个 qa agent.
我看看怎么测试一下效果,能用了,找你讨论下合并。

@deepcoldy deepcoldy marked this pull request as draft June 6, 2026 15:32
@Hellovolcanoone

Copy link
Copy Markdown
Contributor

@leohxj 这个feat,做完了吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants