Repository navigation
Requeue a job inline when its status write-back fails (#1106) - #1201
Closed
rollroyces wants to merge 8 commits into
Closed
rollroyces wants to merge 8 commits into
rollroyces wants to merge 8 commits into
Conversation
deeplethe#610 提案的第一刀。一个来源可以在 config 里写 "precision": "instant"， 连接器就把 created_at / updated_at 写成完整 RFC 3339（与 deeplethe#351 后 change_line 用的同一形式），下游 facts.valid_from_precision 跟着变成 "second"。缺省仍是 day，旧来源的形状不变。 四件事： - Source::precision() 读 config.precision，缺省 day，typo 不翻转 - time_text::world 接受 Some("instant")，输出与无精度路径一致但语义 不同——给抽取器的精度字段是 second，不是 day - github_issues::render_with 接 precision 参数，render() 保持 day 精度 作为旧别名 - ingest_sources::sync_github_issues 把 source.precision() 传给 render_with 测试：721 个全过，3 个新加（time_text 的 instant 路径与跨午夜回归， models 的 precision 默认与 typo 政策，github_issues 的 instant 精度 端到端——含注释/历史/抬头三个时间点）。 设计稿：.roadmap-proposals/instant-precision.md 留待维护者回复的 5 个问题：默认、迁移、typo 政策、doc_time 单独、 JQL 游标。 Signed-off-by: rollroyces <rollroyces@users.noreply.github.com>
fork's default branch is dev; main never gets pushed to here. without this, the CI workflow never fires and the branch-protection status checks on PRs to dev will never report Signed-off-by: rollroyces <rollroyces@users.noreply.github.com>
single-owner fork: every subsystem maps to the only human with push access. Branch protection now requires code-owner review, so the file is meaningful even though self-review doesn't actually block. Subsystems mapped: core data models, ingest connectors (github/jira/ notion/webdav), query_engine/* (PG/MySQL/Trino/Snowflake/Databricks), extract pipeline, store + migrations, reason/search/llm, API + auth, web frontend, docs + roadmap-proposals, build/CI/meta. Default rule (* @rollroyces) catches anything not explicitly listed so a new subsystem inherits review without needing a follow-up edit. Signed-off-by: rollroyces <rollroyces@users.noreply.github.com>
…geTree detection Signed-off-by: Royce Lam <roycelam@umich.edu>
…remock Signed-off-by: Royce Lam <roycelam@umich.edu>
Signed-off-by: Royce Lam <roycelam@umich.edu>
Signed-off-by: Royce Lam <roycelam@umich.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing this PR — I branched off
feat/clickhouse-driverinstead ofdev, so this PR carries the clickhouse cut 2/3 commit history (8 commits, 1622 additions, 21 files) instead of being a focused #1106 fix. The maintainer team closed #1200 yesterday and explained that bundles like this are not mergeable while the clickhouse work is already in rc8 and the rest of the bundle was off-target.Reopening a fresh PR with only the #1106 fix off current
dev. Replacing this one.Keeping the explanation above so the review trail is intact.