CMake: Decouple ELPA dependency from LCAO - #7842
Open
Growl1234 wants to merge 1 commit into
Open
Conversation
Growl1234
marked this pull request as draft
August 20, 2026 12:48
Growl1234
force-pushed
the
cmake
branch
3 times, most recently
from
August 20, 2026 12:57
4d4929c to
948eb5c
Compare
Growl1234
marked this pull request as ready for review
August 20, 2026 12:59
Author
|
The testing failure seems unrelated to this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From investigation and discussion related to #7811 it turns out that ELPA is also used for
diag_subspace 1in PWdav_spacesolver. Therefore,ENABLE_ELPAand compilation ofmodule_genelpaare no longer guarded withENABLE_LCAO.The
if(ENABLE_LCAO)clause is no longer needed asENABLE_PEXSIis handled as dependent option anyways.