Conversation
WardDeb
requested changes
Sep 10, 2026
| shell:''' | ||
| computeMatrix {params.mattype} -p {threads} \ | ||
| -S {params.bws} \ | ||
| 'results/supplemental_figure_combined.pdf', |
Member
There was a problem hiding this comment.
Would be good to have consistent label sizes, axes sizes, whitespace and margins across the subpanels, in line with fig4. PCA could also be A+B as they are 2 panels. cmap on B could also be improved.
| --whatToShow "heatmap and colorbar" | ||
| ''' | ||
|
|
||
| rule multiBigwigSummary_ATAC: |
Member
There was a problem hiding this comment.
Ideally this'd encompass the full example, or at least the ChIPs instead of ATAC alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of example plots for PCA, correlation, and enrichment, using the ATAC-seq example data.
The final plot is combined to generate Supplemental Figure 1.