chore(claude): lift home-directory sandbox restriction in local settings - #440
Merged
Merged
Conversation
Remove the deny rules that blocked Read/Write/Edit on ~/**, along with the negation overrides that re-allowed the project tree. The remaining allow list (Read(*), Write(*), Edit(*), Bash(*)) already covers the workspace paths, so the extra layer is redundant. No impact on production — settings.local.json is per-developer and gitignored on a normal install.
Contributor
Coverage report
Per-file thresholds: 100% on statements / branches / functions / lines (ADR 0002). Files with no branches render |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the deny rules that blocked
Read/Write/Editon~/**in.claude/settings.local.json, along with the negation overrides (!Read(./**), etc.) that re-allowed the project tree on top of them. The remaining allow list already covers everything we need:Read(*),Write(*),Edit(*),Bash(*)for unrestricted workspace access.Read(//tmp/**)for temp-file reads.denylist keeps the dangerous operations blocked: kill/pkill,rm -rf /,sudo,chmod,git rebase,git reset --hard,git clean, etc.The removed layer was redundant: once
Read(*)is allowed, denyingRead(~/**)and re-allowing!Read(./**)cancels out and adds noise without any actual restriction.Files changed
.claude/settings.local.json— 7 lines removed.Impact
Local-only.
.claude/settings.local.jsonis per-developer configuration and is not consumed by CI, builds, or the published@deessejs/fppackage. No runtime, type, test, or documentation changes.Checklist
pnpm --filter @deessejs/fp test:run— N/A (config-only change)pnpm --filter @deessejs/fp lint— N/A (config-only change)