Add alert rules UI (metric alerts phase 1) - #335
Merged
Conversation
|
Preview deleted (PR closed). |
Member
Author
Screenshots (mock data)List — status badges, human-readable conditions Detail — evaluator state + transition history Create/edit form |
List/create/detail pages for metric alert rules (SPEC-metric-alerts.md Phase 1): status badges (ok/firing/nodata), combined create+edit form with deployment picker and notification-channels hint, detail page with transition history and a link to the deployment metrics chart.
Don't flash Not found on a still-valid deployment while the list loads. Reset the threshold when the metric unit changes so cpu 90 does not become a 90 bytes/min egress rule. Default the test mock for notification.list so the empty-channels warning is honest. Suggest alert.* / alert.trigger / alert.resolve on the notification form.
acoshift
force-pushed
the
feat/metric-alerts
branch
from
September 2, 2026 04:49
636e2c5 to
834ec81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Console UI for the new
alertresource (SPEC-metric-alerts.md Phase 1; API: deploys-app/api#133, server: deploys-app/apiserver#249)./alertlist — condition rendered human-readable, status badges (ok/firing/nodata, disabled takes precedence), 60s auto-refresh/alert/create— create + edit (?name=): location/deployment picker, metric/op/threshold/for-minutes, optional renotify, inline warning when the project has no notification channels/alert/detail— evaluator state, transition history (alert.events), link to the deployment metrics chart, gated edit/deleteApitypes, mock fixtures/handlers covering ok/firing/nodata/disabled, 13 Playwright specsScreenshots to follow in a comment.
Testing
bun run check, lint, and full Playwright suite green (394 tests).