Reduce false positives in ADCS and Ghost SPN detection#11
Open
Pebl3 wants to merge 3 commits intodepthsecurity:masterfrom
Open
Reduce false positives in ADCS and Ghost SPN detection#11Pebl3 wants to merge 3 commits intodepthsecurity:masterfrom
Pebl3 wants to merge 3 commits intodepthsecurity:masterfrom
Conversation
Added validation for ADCS detection against catchall NTLM web apps and introduced a new method to check for catchall NTLM paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logan full disclaimer... this is completely vibe-shat straight out of Anthropic's ass cheeks. Manually validated that code works as intended and reduced bloat.
Reduce false positives in ADCS and Ghost SPN detection
Both detectors were treating a single weak signal as proof, producing CRITICAL findings on benign infrastructure. This PR adds validation probes so unconfirmed signals get a softer label
(or are dropped) instead of triggering CRITICAL.
ADCS (
protocols/http_detector.py,core/relay_analyzer.py)The HTTP detector flagged
is_adcs=Truewhenever/certsrv/appeared in matched NTLM paths. On servers that 401-NTLM every URL (catchall web apps with site-wide Windows auth),/certsrv/always matches even when no CA is installed._is_catchall_ntlm()which probes two random bogus paths. If both also 401-NTLM, it's a catchall and/certsrv/is not proof of ADCS — setadcs_unconfirmedinstead ofis_adcs."/certsrv/ matched but ADCS unconfirmed (catchall NTLM site)"rather than CRITICAL ESC8.Ghost SPN (
detectors/ghost_spn.py)E3514235-4B06-11D1-AB04-00C04FC2DCD2) — these are Kerberos-only._msdcs.<domain>CNAMEs, not via the GUID name itself.discover what the wildcard actually returns, then only flag candidates whose IPs match — real A records get dropped.