Skip to content

Give the conjunctions, bound given names and birth markers their languages (#751) - #780

Merged
derek73 merged 3 commits into
masterfrom
feat/und-languages-751
Oct 20, 2026
Merged

derek73 merged 3 commits into
masterfrom
feat/und-languages-751

Conversation

@derek73

@derek73 derek73 commented Oct 20, 2026

Copy link
Copy Markdown
Owner

Closes #751.

This moves the last 44 words out of nameparser/vocab/und.toml into the files of the languages whose names they occur in. That leaves und.toml with only bon and dí: two particles with no record of which names they come from, whose removal is #766's question. A comment at the top of the file says so.

No compiled set moves. tools/vocab/build.py --check reports _compiled.py current, tools/differential/snapshot.py matches, and the word-order check passes.

Where they went

Each word went where its own record put it:

ca.toml and nn.toml are new files.

Comments became fields

  • The single-letter-connective comment block is gone. Its general reasoning is already in decisions/P8 and rules/P3. Its per-word facts are now notes on e and i, and its keep-outs, y and the Cyrillic и, і and й, are excluded = { may_be_initial = … }.
  • The Provide constants in non-Latin scripts (Cyrillic, Greek, Arabic, Hebrew) #269 comment blocks became an issue on each word, plus notes on і, و and عبد. abd's comment is now its note in ar.toml.
  • Spellings carry same_as, for example abdel → abdul, й → і, nee → née, and the е spellings → the ё ones.
  • Gender is recorded where the form marks it.
  • Two keep-outs that were only prose in decisions/vocabulary-exclusions are now exclusions:
    • roz in cs.toml, removed 2026-08-26. I measured it again: with roz listed, Rosalind Roz Smith reads maiden 'Smith' and takes Rosalind for the family.
    • the Scandinavian f. in da.toml, which collides with the initial F.

Docs

  • decisions/vocabulary-model has a new part-2 entry.
  • decisions/vocabulary-exclusions' conjunctions_ambiguous and maiden-marker blocks now point at the queries.
  • nameparser/vocab/README.md's und paragraphs and the RFC's phase table are updated.

Review

Two docs-review rounds, the second on the fix commit:

  • The first found that the intro claimed every maiden-marker refusal had become data, that nee was placed against the docstring the entry cites, and that the en.toml née/né had no gender. All three are fixed.
  • The second found a README total that the fix commit had made stale. That count is now gone.

Suite: 22,122 passed. mypy and ruff are clean.

🤖 Generated with Claude Code

derek73 and others added 3 commits October 20, 2026 01:36
…uages (#751)

The last 44 words in und.toml but bon and dí move to the files of the
languages whose names they occur in, by the record each one carries:
the #269/#397 conjunctions to en, fr, de, es, pt, it, ca, pl, ru, bg,
uk, el and ar, with & in mul; the bound given names to ar; the birth
markers by the #274 module docstring, with z domu in pl and 旧姓 in ja.
ca.toml and nn.toml are new. No compiled set moves; the snapshot
matches.

The vetting comments become fields: notes and issues on the
connectives, the y and Cyrillic may_be_initial keep-outs become
exclusions, abd's comment is its note in ar.toml, and roz, removed
from the birth markers on 2026-08-26, is an exclusion in cs.toml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ke f. a refusal

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 added enhancement vocabulary Per-word vocabulary model and language packs labels Oct 20, 2026
@derek73 derek73 self-assigned this Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (85ac416) to head (9fa0300).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #780   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          47       47           
  Lines        4642     4642           
=======================================
  Hits         4598     4598           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit af450cd into master Oct 20, 2026
12 checks passed
@derek73
derek73 deleted the feat/und-languages-751 branch October 20, 2026 08:59
@derek73 derek73 added this to the 2.6 milestone Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement vocabulary Per-word vocabulary model and language packs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assign languages to the credentials and the remaining und.toml words

1 participant