Skip to content

Fix pagination icons rendering as raw text#487

Merged
dereuromark merged 1 commit intomasterfrom
fix/pagination-icons-escape
May 3, 2026
Merged

Fix pagination icons rendering as raw text#487
dereuromark merged 1 commit intomasterfrom
fix/pagination-icons-escape

Conversation

@dereuromark
Copy link
Copy Markdown
Owner

Summary

PaginatorHelper only honors 'escape' => false'escapeTitle' => false is silently ignored. The FontAwesome <i> tags in the pagination element fell back to the default escaped path and rendered as literal HTML text.

Fix

Revert the four 'escapeTitle' => false to 'escape' => false. Verified in CakePHP source: PaginatorHelper::prev/next/first/last/sort all use only the escape option.

Switched the Paginator nav titles from escapeTitle => false to
escape => false. PaginatorHelper only honors the escape option —
escapeTitle is silently ignored — so the FontAwesome <i> tags fell back
to the default escaped path and rendered as literal HTML text.

Verified in cakephp/cakephp PaginatorHelper: prev/next/first/last/sort
all use only the escape option, with no narrower title-only equivalent.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 3, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.54%. Comparing base (22cbe5b) to head (6971973).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #487   +/-   ##
=========================================
  Coverage     77.54%   77.54%           
  Complexity      966      966           
=========================================
  Files            45       45           
  Lines          3238     3238           
=========================================
  Hits           2511     2511           
  Misses          727      727           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereuromark dereuromark merged commit 8a7c89c into master May 3, 2026
16 checks passed
@dereuromark dereuromark deleted the fix/pagination-icons-escape branch May 3, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants