Clean up event alerts and ensure reliable dedupe#259
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors EventAlertJob’s Slack alert formatting to produce cleaner, more structured event notifications by splitting occurrences into “Happening today” vs “Upcoming in the next 24 hours” buckets.
Changes:
- Added UTC-day helpers and bucketing logic to separate “today” occurrences from later occurrences within the same 24-hour lookahead.
- Extracted alert formatting into reusable helpers (
formatOccurrenceLine,formatAlertSection,formatAlertMessage). - Updated/added unit tests to assert the new message headers and two-message behavior when both buckets exist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/backend/src/jobs/event-alert.job.ts | Adds UTC-day bucketing and refactors Slack message formatting; may send up to two messages per run/team. |
| packages/backend/src/jobs/event-alert.job.spec.ts | Updates expectations for new “Happening today” header and adds coverage for splitting today vs later occurrences. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+162
to
+169
| if (upcomingMessage) { | ||
| await this.webService.sendMessage(ALERT_CHANNEL, `${upcomingMessage}${overflowLine}`); | ||
| } | ||
|
|
||
| // Always send today alerts last when both buckets have events. | ||
| if (todayMessage) { | ||
| await this.webService.sendMessage(ALERT_CHANNEL, `${todayMessage}${overflowLine}`); | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot
AI
changed the title
Updated alerts to be cleaner
Clean up event alerts and ensure reliable dedupe
Jun 9, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines
EventAlertJobalert formatting and fixes dedupe reliability for split alert sections.The job now still separates occurrences into:
But when both sections exist, it sends them as a single combined Slack message instead of two separate posts. This prevents partial-send scenarios from causing duplicate re-alerts on retry, since dedupe keys are written after one successful send.
Updated unit tests in
packages/backend/src/jobs/event-alert.job.spec.tsto validate the single-message behavior and section content.