Repository navigation
feat(screen-plan): follow the final design page; audit treats headless-hidden scrollbars as visible - #110
Draft
devfive-relay-c70423[bot] wants to merge 162 commits into
Conversation
added 30 commits
October 22, 2026 17:15
…s-hidden scrollbars as visible State-variant frames (Desktop 1441, Mobile 361/362, extra form states) fold into their route instead of becoming new screens, and remap moves a route to a newer frame. The runtime audit no longer reports overflow:auto tab strips and tables as clipped just because headless Chromium hides every scrollbar; only scrollbar-width:none still counts.
…itted file writes
…den exclude words
… used for asset file names
…checks, erd gate, merged screen answers
…ope fields and a narrowed recovery call
…ng else can shrink the response
… is shared; add r14 test
Existing envelope spill fixes cover the reported single-frame scenario. Assume synthetic 569-issue metadata reproduces its transport pressure without retaining private design data.
Reuse existing narrowed recovery and spill behavior. Assume top eight serialized JSON fields are the useful diagnostic budget; preserve total retained output bytes when checking the resource envelope.
Reuse one stem for identical image hashes across layer roles and preserve variant identity. Refresh codegen snapshots and fixture checksums for kebab-case asset paths; refresh platform float serialization in the diagnostics snapshot.
Keep existing manifest auto-add behavior, disclose it, select job fields after job attachment, and judge requested captures rather than all discovered assets. Assume nodes paths remain capture-scoped while other paths prefer the assembled reply. Exercise MCP calls and actual output file bytes in regression coverage.
…s (30) Existing original-source defaults already choose WebP q85. Apply the display-width times two cap when omitted and auto-select lossless encoding for alpha graphics with at most 256 colors. Explicit codec and lossless choices remain authoritative.
Keep the existing shared manifest-to-TSX reconciliation, verified by its real-file dedup regression. Add required placeholder paths to reviewChecklist even when acquisition itself is complete.
Resolve node requests to captured fill evidence before determining write state, and avoid reporting a request's own internal fill as a duplicate. Existing partial/resume and request-count regressions remain covered.
Assume legacy plans without app fields remain valid; explicit route app bindings must match. Search all ancestors rather than four levels.
…es (19) Assume existing section-based device renaming is authoritative; reproduce Main Desktop/Mobile alongside another section without a mobile URL.
added 30 commits
October 24, 2026 02:46
…nto devfive/3099154426bffbeef8b62999b80bb038/screen-plan-final-frames
…devfive/3099154426bffbeef8b62999b80bb038/screen-plan-final-frames
…o devfive/3099154426bffbeef8b62999b80bb038/screen-plan-final-frames
…o devfive/3099154426bffbeef8b62999b80bb038/screen-plan-final-frames
…nto devfive/3099154426bffbeef8b62999b80bb038/screen-plan-final-frames # Conflicts: # crates/devup-mcp/src/server/text/devup-project-plan.md
- quote non-identifier lookup keys (button set produced invalid TSX) - treat an aborted OXC parse as a validation error (parserAborted) - expose unbound TEXT nodes in a component set as string props with the Figma copy as default - drop set-canvas placement from variant roots, keep a containing block for absolute descendants - emit cond ? value : undefined instead of cond && value
…ext prop names - account for diagnosed variant-child fallback nodes as ignored trace entries so componentTsx no longer fails the exactly-once check (ApplicationsCard, RnDLinkRow, TechStep) - give non-ASCII declared TEXT properties unique identifiers instead of overwriting defaults
…ops, partial variant maps, boolean props and state selectors - keep typography and Image src scalar across responsive variants - add undefined branches for variant lookups missing union keys - declare and destructure referenced boolean props with collision-free names - map selected/hoevr states to valid selectors; keep src out of pseudo objects
…src off container variant merges - one-sided responsive Image src becomes scalar src plus endpoint visibility - source splitting only applies to Image; container merges never take a leaf variant's src - guard test across all chondrogen fixtures: no scalar arrays, no src on non-Image elements
…nd keep boolean-controlled layers - variant lookups use Definition.source, so icon/mask/src/state styles are no longer dropped (empty Caret/Logo/DropdownOption bodies) - children with a visible property reference count as visible for asset classification (IconButton text layer) - responsive expressions drop redundant trailing inheritance and collapse slot-0-only arrays to scalars - guard test: every declared prop is referenced in the body
…ps href, and treat controls inside links as wired
…primitive as a dynamic target, not unmapped
…itory root holds from an app directory, and status never takes another app's page for a route
…nparsed files, not truncated component lists
…ly variant of a text component set stays a component reference
…ces a vector-only variant when another width's instance of the set has text
The plugin reports its scripts hash and protocol; status and exports flag a stale plugin. A plugin that reports liveScripts and speaks the same protocol is sent this build's scripts over the bridge socket (scripts-update), swaps them in and says hello again with the new hash, so a rebuilt server reaches an open plugin without closing and re-running it.
…ic URLs and settled scroll reveals
… and component references
…ame the token kind, keep bridge source under the line limit
stack_diff openapi-client and feature_trace recognised only a receiver named api, so a project calling client.get('/posts') through 'export const client = createApi(...)' reported callsChecked 0. Bindings to createApi are now collected project-wide and followed through imports and aliases. The hardcoded-length suggestion no longer says colors. bridge/stamp_file_key.rs was split (fallback_reasons.rs) to stay under the 1000-line source limit.
…ths, prefer purpose-matching tokens - summary mode groups hardcoded-length/color findings by (rule, severity, value, tokens) across files, with count, props and files[].lines - 0px lengths are never reported - tokens named for another purpose (radius/stroke/space/size/text) are info without replacement advice; same-purpose tokens are preferred - mode advice is stated once (suggestion + tokenMatches), findings carry value/prop context - corrected_tsx only considers the tokens the finding actually suggested
…ut risks point at their element - summary rows are ordered error, warning, info before the 100-row cap; violationsTruncated reports hiddenBySeverity - column-reading-order, narrow-fixed-columns and navigation-fit carry the byte offset of the element they judge, so line/column are real instead of 1
…d value A sourceMap entry's variableId now reaches the violation as designBinding: bound means use the token generated for that variable rather than one that merely shares the value; unbound means the design hardcodes it too. Summary rows keep it and group by it.
…s info With the export's sourceMap, a hardcoded-color/hardcoded-length warning whose Figma node binds no variable drops to info with no token replacement: a theme token that only shares the value is a coincidence. Runs before severities are counted, so ok, okReason, strict and correctedTsx agree. Bound values stay warnings.
…easure Each hardcoded-length finding carries lengthKind (radius, stroke, space, size, text, other) and summary rows group by it, so a 12px radius no longer shares a row (and its token message) with 12px spacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remapmoves an existing route to a newer frame.--hide-scrollbars). Because of that,no-clipped-contentreported plainoverflow-x: autotab strips and tables as clipped content. The runner now probes whether the browser hides scrollbars, and in that case onlyscrollbar-width: nonecounts as an invisible scroller. Covered by a new case intest/layout.test.mjs.componentTsxworks when the root is a component set, a single variant or an instance, and is named after the set.data-figma-node-idis only emitted withfigmaNodeIds: true. Instances resolve to their component. Link hover/focus states sit on the element rendered as the link.limitis an input error. Trash/hidden frames are flagged. BridgereferencePngaccepts a single frame id and reports PNGs it can't render instead of dropping them.confirmno longer overwrites model files and drops columns that exist on disk (55).statuswithoutplanIdreturns recovery actions.intakeon an existing plan offers resume or an archived restart. Column type errors and model drift are reported. Recommendations follow recorded evidence.auditPlanrun fromapps/frontfinds the plan at the monorepo root, and a rerun refreshes its own output. 14 and 15 were already fixed; regression tests added.document.bodyor a failing probe makes that one check inconclusive instead of aborting the run. Checks anchored on node ids absent from the source arenot-runwith a reason.auditPlanreturns the exact dev-server start command (the runner does not start it itself). 46 was already fixed.figma-bridge-setupskill. No instruction to add an audit plugin to the app build config. Component-first workflow: export components withcomponentTsx, record.devup/component-map.json, then assemble pages; no hand-written TSX from Figma nodes.Not done in this PR: the runner starting the dev server itself (60), a
devup_figma_bridge ensuretool and stale-host/out-of-view next actions in status (48), section-level export (65), and the legacy strip-plugin file still emitted byauditPlan(64).Follow-up commits
feat(bridge)pluginStale,DEVUP_BRIDGE_PLUGIN_STALE). Live script updates: a plugin that sendsliveScripts: trueand speaks the same protocol is sent this build's scripts over the bridge socket (scripts-update). It swaps them in and says hello again with the new hash, so a rebuilt server reaches an open plugin without closing and re-running it. A bundle that fails to load leaves the current scripts in place. Plugins built before this change need one manual re-run.feat(ui-validate)paths.feat(screen-plan,audit)docs(skills)figma-bridge-setupchecks status again before a manual rebuild.feat(codegen,export)fix(stack-diff,ui-validate)stack_diffopenapi-client andfeature_traceonly recognised calls on a receiver namedapi, soclient.get('/posts')throughexport const client = createApi(...)gavecallsChecked: 0. They now collectcreateApibindings across the project and follow them through imports and aliases. Thehardcoded-lengthsuggestion no longer says "colors".bridge/stamp_file_key.rsis split (fallback_reasons.rs) to stay under the 1000-line source limit.fix(ui-validate)35b0affdevup_ui_validate pathson chondrogen. Summary mode now groupshardcoded-length/hardcoded-colorfindings by value and token across the whole project, withcount,propsandfiles[].lines(chondrogen hit the 100-row cap with the samegap 8pxrow per file).0pxlengths are not reported. A token named for another purpose ($spacing24for a radius, a stroke-width token for a height) is info with no replacement advice; a same-purpose token is preferred. Mode advice is stated once.correctedTsxonly uses the tokens a finding suggested.fix(ui-validate)2d72c83violationsTruncated.hiddenBySeveritycounts what was cut. Layout risks point at the element they sit on.fix(ui-validate)1ee3d8fsourceMap, eachhardcoded-*finding now hasdesignBinding:bound(withvariableIds) means use the token generated for that variable, not one that just shares the value;unboundmeans the design hardcodes it too, sotokenMatchesare a coincidence of values.SourceMapEntryInputacceptsvariableId, and summary rows keep and group by the binding state. Test:hardcoded_values_report_the_figma_binding_behind_them(full and summary, bound and unbound).fix(ui-validate)d6617b3hardcoded-color/hardcoded-lengthwarning whose Figma node binds no variable now drops to info and drops the token replacement advice; the summary message says the design hardcodes it too. This runs before severities are counted, sook,okReason,strictandcorrectedTsxagree. Bound values stay warnings. Without asourceMapnothing changes. Test:an_unbound_value_matching_a_token_is_info(strict, full and summary, bound and unbound).fix(ui-validate)bf9a149hardcoded-lengthfinding carrieslengthKind(radius,stroke,space,size,text,other), and summary rows group by it. A 12pxborderRadiusno longer shares a row, and its token message, with 12pxgap. Test:summary_rows_split_lengths_by_kind.Needs a maintainer: the push token cannot change workflow files, so
.github/workflows/ci.ymldoes not yet run the newplugin/tests/live-scripts.test.mjs. Add it to thenode --testline afterplugin/tests/withdraw.test.mjs.Live-script checks:
cargo test -p devup-mcp-figma(includingtests/live_scripts.rsand the bundle fingerprint),devup-mcpskills/diagnostics/bridge_first/bridge_relaytests, clippy-D warnings,fmt --check, pluginnpm run build/verify,tsc --noEmit, andnode --test(11 pass) all pass.Verification
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceharness/runtime-auditnpm testcargo clippy -p devup-mcp --all-targets -- -D warnings,cargo test -p devup-mcp --test ui_validate_responsefmt --check,cargo test -p devup-mcp --test ui_validate_response-D warningsondevup-mcpanddevup-mcp-devup-ui,fmt --check,ui_validate_response(81) andcargo test -p devup-mcp-devup-ui*
r3_asset_job_timeout_keeps_first_asset_and_resumes_pending_readfailed once on the first full run and passed alone (3/3) and on the next two full runs. It uses a paused clock and looks timing-sensitive under load.Tested on chondrogen (14 routes, 5 widths: 1440/1100/858/390/360)
Earlier in this PR, before the feedback batch. Plans were regenerated with
devup_screen_plan auditPlanand run with the updated runner.//company/company/vision/company/location/technology/technology/research/technology/osteoarthritis/technology/patents/technology/achievements/products/products/oa-model/news/news/notice/contact* The 5 failures on
/were a real finding: a decorative marquee in a 1.22:1 colour. It was fixed in the app (aria-hidden), not in the runner.Remaining:
/productshas 5no-low-contrast-textresults that are inconclusive, where 2 text samples have backgrounds that can't be judged./news/[id]is not audited because no static params or detail-frame text are available.chondrogen app checks after the changes:
bun run lint:fix,oxlint --deny-warnings,tsc --noEmit,bun run build,bun test(4 pass, 100% coverage) all exit 0.Submitted via Devfive hub. Employee: ; device:
3099154426bffbeef8b62999b80bb038