fix: 未使用変数を削除してShellCheckのエラーを解消 - #40
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
mainで落ちていた Shell Script Lint（ShellCheck）を修正します。原因
scripts/android_setup.shのCMDLINE_TOOLS_ROOTが未使用で、SC2034 が出ていました。81dbaf8 のリライトで、旧
SDK_DIRがCMDLINE_TOOLS_ROOTにリネームされた一方、参照側（sdkmanager --sdk_rootとflutter config --android-sdk）は新設のSDK_ROOTに統一されたため、この変数だけ参照元がない状態で残っていました。リポジトリ全体を検索しても他に参照はありません。変更内容
未使用となっていた
CMDLINE_TOOLS_ROOTの定義を削除しました。sdkmanagerはcommand -vで PATH から解決しているため、動作への影響はありません。動作確認
CI と同じコマンドをローカルで実行し、エラーが解消されたことを確認しました。
zsh -n scripts/android_setup.shによる構文チェックも通っています。🤖 Generated with Claude Code