Repository navigation
fix: sandbox package settings stay stale after image updates - #359
Merged
Merged
Conversation
devSejung
force-pushed
the
fix/sandbox-pip-mirror
branch
from
October 22, 2026 07:44
b29a72e to
a5132d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where sandbox package installs kept using obsolete pip settings after an operator loaded a rebuilt image with the same source tag. The transfer builder embeds an external credential-free
pip.conf, so that file can change without changing the source tag; comparing only tag strings left existing sandboxes on the old image.Why This Change Was Made
Always retire managed sandboxes after the image update passes health checks, through the existing deployment lifecycle. This removes the tag-equality shortcut and preserves the existing failure/rollback flow. Production delta is +2 lines, both explanatory comments; executable code is line-neutral. Tests are +15 lines net. No config keys or defaults are added or changed.
User Impact
Both
image setandimage updatenow make the next agent run use the loaded sandbox image even when refs are unchanged. The operator documentation explains the private build input, global pip settings, rebuilding both transfer artifacts, and workspace virtual environments. Internal repository addresses and the local pip configuration remain outside Git. Existing sandboxes are retired during an explicit image update, consistent with changed-ref updates.Evidence
setandupdatefailures using the original deployment script: sandbox retirement was missing.node scripts/platformclaw-check.mjs --changed --overlay-only --base 5109dcad941e461593b6a64b5588bcab029b66de --head HEAD, followed by the upgrade lifecycle suite (87 tests total). Lint, formatting, all 258 script declaration contracts, SDK declaration preparation, shell syntax, and root test typecheck passed. Shared upstream checks are delegated to the existing PR CI workflow.c77f0370ea9(git range-diffconfirms equality).The local company build input was corrected separately; that private file is intentionally absent from this PR. This PR does not publish a release or change the running company server.
CI repair
The previous head failed only the gateway-help process-exit case in the compact Node CLI shard. Rebased onto main to include the already merged one-shot native-work drain fix from #354 (aadc3dd), preserving this PR's five-file deployment diff. On the rebased Linux source, all 26 help-exit tests pass; the originally failed traced gateway-help case exits successfully in about 1.9 seconds. No timeout increases, test weakening, or duplicate CLI workaround were introduced.
Focused rebased-head Linux verification: 59 tests passed across help-exit, gateway-backed exit, one-shot process/unit, and deployment upgrade suites.