Repository navigation
feat: simplify Skill Hub sharing and Basic/VM transfers - #415
Merged
Merged
Conversation
devSejung
marked this pull request as ready for review
October 28, 2026 06:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #406
What Problem This Solves
Ordinary employees, including users with no organization, could hit namespace permissions and visibility ceilings when publishing a skill. Basic and VM transfers, existing Public skill updates, uncertain upload recovery, and shared-room access also followed conflicting rules.
Why This Change Was Made
Implement the approved policy through one employee catalog and the existing private artifact registry. New skills default to Public for active company accounts; Selected and Private remain explicit choices. Existing eligible skills move to Public once without overriding later sharing changes. Native namespaces remain a private artifact detail rather than an employee permission boundary.
The catalog owns sharing, ownership, metadata, Trash, and auditing. The registry owns immutable versions, original archives, historical malware evidence, and confirmed physical deletion. Registry identity is reserved and durably bound before uploading bytes, so canceled first publications can also be cleaned up.
User Impact
/skillhub --lang=enor--lang=ko. Raw failure diagnostics and request IDs remain available. Narrow mobile sharing controls stay inside the dialog.Evidence
Based on main
d46f20ff0a70e8e76f1060082168731783181ac9. Current head:7a6eb9ca311916aff78bd55b0be87bb17ec6705f; treec0539e6ac9b656e6c2a47da82a9deba2d81a3f6e.Independent review covered the complete implementation and fresh scoped reviews of every follow-up. All accepted P0–P2 findings have been addressed. The workspace cancellation repair preserves the draft and selected target while issuing a fresh operation ID after confirmed cancellation.
Validation used task-owned Ubuntu Docker, Node 24.18.0, pnpm 11.15.1 and Chromium 151:
pnpm --dir ui test --maxWorkers 3passed all 707 files / 9,963 tests with one existing skip; six routing checks, lint and formatting passed. The local pre-fix full run also passed, so the hosted order-dependent failure is not claimed as locally reproduced.The current head's hosted CI is pending. No merge or deployment is included.
Proof boundaries: seeded authentication does not prove company SSO. VM proof uses a task-owned real Linux SSH fixture rather than a company production VM. Credentialed S3 and paired production Control/Registry restoration retain separate operational proof. Common host command pre-authentication retains its existing English text.
Shared-room filesystem masks retain real Docker evidence for matching source owners, with fresh Linux real-filesystem regressions for the corrected final guard. An additional whole-final-source Docker room rerun was blocked by the tool safety filter and is not claimed as passing.
English Basic workspace publication, default Public:
Korean VM installation on mobile, with Basic and VM kept independent: