Repository navigation
fix(deps): bump loft-sh/kubernetes from 77fe896 to dff9087 in /pkg/fsutil/configmanager/vcluster - #8060
Conversation
Bumps loft-sh/kubernetes from `77fe896` to `dff9087`. --- updated-dependencies: - dependency-name: loft-sh/kubernetes dependency-version: v1.37.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
![ksail-bot[bot]](https://avatars.githubusercontent.com/in/2880167?s=60&v=4){kind=small}
✅
|
Preserve all-status release inspection and rollback on Helm 3 and 4. Exercise the Helm 4 command boundary and reject pending, ambiguous, and unsupported-version evidence. Part of #8073.
Pull request was converted to draft
Adaptation prepared at The existing chart-values fixture reproduced the real Helm 4 Validation: full Go suite passed; the complete CI harness passed; the final values-trial tests also passed under Bash 3.2. Build and CLI help passed. Focused Go lint, ShellCheck, shfmt with the repository indentation, and diff checks passed. The native Helm 4 list and upgrade argument forms parse successfully. These local checks do not establish the real cluster upgrade and repeated no-op. Correctness and scope review found no additional blocking issue in the adaptation. Dependency review: this remains the This PR stays draft with auto-merge disabled. Next gates: ordinary CI at this exact head must reach and pass the real component-values upgrade and repeated no-op, then obtain an independent current-head review. The separate main cancellation repair is #8077; no main recovery is claimed here. |
Code coverage overviewLanguages: Go Go / code-coverage/go
View coverage of the 3 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
devantler
left a comment
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
The Helm 4 adaptation at e91bdd8c35651e0a2e77c33c0553c8aa3ede7599 still leaves the Calico migration trial unable to run. The Vanilla job and K3s job both stop with Error: unknown flag: --all before proving migration.
The unchanged Calico trial invokes helm list --all for both its before and after release snapshots (lines 48 and 145). I independently reproduced the parser rejection with installed Helm v4.3.1 using an empty kubeconfig; no cluster was contacted.
Extend the major-version handling to both snapshots and make the Calico fixture reject Helm 3-only flags when emulating Helm 4, while retaining Helm 3 and failed/pending-release controls. This is remaining work under #8073, not a new issue. The separate Vanilla chart-values job also failed; its cause and the actual values-upgrade/repeated-no-op proof remain unverified. This review does not establish merge readiness.
The system tests here still fail on Helm 4 after
#8083 carries |
Why
The pinned vCluster Kubernetes image has a refreshed build, but its update is blocked by chart checks that use an unsupported Helm 4 option.
What
Adopt the refreshed image and keep the chart checks working with Helm 3 and Helm 4 while preserving release-health and ownership safeguards.
Part of #8073