Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions cgmanifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -1510,16 +1510,6 @@
}
}
},
{
"Component": {
"Type": "git",
"Git": {
"Name": "nvs",
"repositoryUrl": "https://github.com/jasongin/nvs",
"commitHash": "6b20e9f750ea371bd347e5dbac8406d677292b60"
}
}
},
{
"Component": {
"Type": "other",
Expand Down
2 changes: 0 additions & 2 deletions src/universal/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"version": "24",
"additionalVersions": "22"
},
"./local-features/nvs": "latest",
"ghcr.io/devcontainers/features/python:1": {
"version": "3.14.2",
"additionalVersions": "3.13.8",
Expand Down Expand Up @@ -84,7 +83,6 @@
"ghcr.io/devcontainers/features/dotnet",
"ghcr.io/devcontainers/features/hugo",
"ghcr.io/devcontainers/features/node",
"./local-features/nvs",
"ghcr.io/devcontainers/features/conda",
"./local-features/patch-conda",
"ghcr.io/devcontainers/features/python",
Expand Down

This file was deleted.

79 changes: 0 additions & 79 deletions src/universal/.devcontainer/local-features/nvs/install.sh

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"ORYX_ENV_TYPE": "vsonline-present",
"PYTHONIOENCODING": "UTF-8",
"NPM_GLOBAL": "/home/codespace/.npm-global",
"NVS_HOME": "/home/codespace/.nvs",
"RVM_PATH": "/usr/local/rvm",
"RAILS_DEVELOPMENT_HOSTS": ".githubpreview.dev,.preview.app.github.dev,.app.github.dev",
"GOROOT": "/usr/local/go",
Expand Down
6 changes: 3 additions & 3 deletions src/universal/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ The container includes the `zsh` (and Oh My Zsh!) and `fish` shells that you can
You can decide how often you want updates by referencing a [semantic version](https://semver.org/) of each image.
For example:

- `mcr.microsoft.com/devcontainers/universal:6-noble`
- `mcr.microsoft.com/devcontainers/universal:6.0-noble`
- `mcr.microsoft.com/devcontainers/universal:6.0.8-noble`
- `mcr.microsoft.com/devcontainers/universal:7-noble`
- `mcr.microsoft.com/devcontainers/universal:7.0-noble`
- `mcr.microsoft.com/devcontainers/universal:7.0.0-noble`

See [history](history) for information on the contents of each version and [here for a complete list of available tags](https://mcr.microsoft.com/v2/devcontainers/universal/tags/list).

Expand Down
3 changes: 1 addition & 2 deletions src/universal/manifest.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "6.0.8",
"version": "7.0.0",
"build": {
"latest": true,
"rootDistro": "debian",
Expand Down Expand Up @@ -87,7 +87,6 @@
"git": {
"Oh My Zsh!": "/home/codespace/.oh-my-zsh",
"nvm": "/usr/local/share/nvm",
"nvs": "/usr/local/nvs",
"rbenv": "/usr/local/share/rbenv",
"ruby-build": "/usr/local/share/ruby-build"
},
Comment thread
Kaniska244 marked this conversation as resolved.
Expand Down
8 changes: 4 additions & 4 deletions src/universal/test-project/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ checkDirectoryOwnership "codespace user has ownership over extension directory"
# Node.js
check "node" node --version
check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm --version"
check "nvs" bash -c ". /usr/local/nvs/nvs.sh && nvs --version"
check "yarn" yarn --version
check "npm" npm --version
count=$(ls /usr/local/share/nvm/versions/node | wc -l)
Expand Down Expand Up @@ -136,9 +135,10 @@ check "default-node-version" bash -c "node --version | grep 24."
check "default-node-location" bash -c "which node | grep /home/codespace/nvm/current/bin"
check "oryx-build-node-project" bash -c "oryx build ./sample/node"
check "oryx-configured-current-node-version" bash -c "ls -la /home/codespace/nvm/current | grep /opt/nodejs"
check "nvm-install-node" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 8.0.0"
check "nvm-works-in-node-project" bash -c "node --version | grep v8.0.0"
check "default-node-location-remained-same" bash -c "which node | grep /home/codespace/nvm/current/bin"
check "nvm-switches-to-additional-node-version" bash -c ". /usr/local/share/nvm/nvm.sh && nvm use 22 && node --version | grep v22."
check "node-location-after-switching-to-22" bash -c "which node | grep /home/codespace/nvm/current/bin"
check "nvm-switches-back-to-default-node-version" bash -c ". /usr/local/share/nvm/nvm.sh && nvm use default && node --version | grep v24."
check "node-location-after-switching-back-to-default" bash -c "which node | grep /home/codespace/nvm/current/bin"

# Ensures sdkman works in a Java Project
check "default-java-version" bash -c "java --version"
Expand Down
Loading