Skip to content

Wait a frame for Find's active highlight in its browser test #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thesiti92 merged 1 commit into from
Oct 8, 2026
Merged

Wait a frame for Find's active highlight in its browser test #1033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/review/app/src/review-find-controller.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,15 @@ it("orders duplicate editors with MDX and wraps navigation", async () => {
"::highlight(review-find-match)",
).backgroundColor,
).toBe("rgb(10, 20, 30)");
expect(
getComputedStyle(
container.querySelector("article")!,
"::highlight(review-find-match-active)",
).backgroundColor,
).toBe("rgb(40, 50, 60)");
// The active match is highlighted on the next frame.
await vi.waitFor(() => {
expect(
getComputedStyle(
container.querySelector("article")!,
"::highlight(review-find-match-active)",
).backgroundColor,
).toBe("rgb(40, 50, 60)");
});
// The shell is the widget's containing block.
expect(
container.querySelector(".review-find-widget")?.parentElement,
Expand Down
Loading