Skip to content

fix(ci): report desktop check for diffr-only changes - #1085

Merged
sidkmenon merged 1 commit into
mainfrom
sm/ci
Oct 10, 2026
Merged

sidkmenon merged 1 commit into
mainfrom
sm/ci

Conversation

@sidkmenon

@sidkmenon sidkmenon commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Diffr-only PRs leave the required Review Desktop check pending because paths-ignore prevents the entire workflow from reporting a result.

Run the workflow on every PR and detect changes outside diffr/ before scheduling the desktop build. Preserve Review Desktop as an always-running result check: it passes for diffr-only changes or a successful required build, and fails if detection or the required build fails. Manual dispatch still runs the full build.

Validation: actionlint passed; exercised the detection script against temporary Git repositories covering diffr-only and mixed changes, shared files, workflow changes, renames across the directory boundary, base-branch drift, and invalid revisions. Checked all 48 combinations of detection/build results and required-build output. GitHub CI passed: change detection, the full desktop build/test job, and the required Review Desktop result check (run).

Agent-Session: 8881e3f3-a916-4405-9706-bb6e3a2f193d
Agent-Session: 01a127c4-196c-7472-a943-6cb22a2f1c4a
Agent-Session: 01a127c7-65e6-7990-92ae-58fbb2927383
@sidkmenon
sidkmenon merged commit 9171838 into main Oct 10, 2026
3 checks passed
@sidkmenon
sidkmenon deleted the sm/ci branch October 10, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants