Skip to content

Move the copy controls into the UI kit - #1124

Merged
thesiti92 merged 3 commits into
remote/16-windows-remote-hostsfrom
ui/copy-text-kit
Oct 15, 2026
Merged

thesiti92 merged 3 commits into
remote/16-windows-remote-hostsfrom
ui/copy-text-kit

Conversation

@thesiti92

Copy link
Copy Markdown
Contributor

copyText, CopyableText and CopyButton move from packages/review/app/src/copy-text.tsx into the UI kit as @canvas/ui/copy, with one copy glyph instead of two. The kit stays free of app code: the components take their tooltip from a kit-owned host context (ui/host.tsx) whose default does nothing, and the app installs UiHostProvider with its useTooltip once at each root.

Stacked on #1114.

Test plan

  • Browser tests for the touched files and the review package tests.
  • Root typecheck and lint.
  • In Desktop: hover a hand-install hint in Settings shows "Click to copy", clicking copies it and shows "Copied"; the copy button on a prompt card still copies.

@thesiti92
thesiti92 force-pushed the ui/copy-text-kit branch 2 times, most recently from 0ad4fc5 to 65db91c Compare October 15, 2026 01:14
@thesiti92
thesiti92 added this pull request to stack #1148 October 15, 2026 01:14
copyText, CopyableText, CopyButton and the single copy glyph now live in @canvas/ui/copy, and prompt cards use that glyph instead of their own inline SVG. The kit reads tooltips from a UiHostProvider context that the app installs at its two roots, so it stays free of host imports.
@thesiti92
thesiti92 merged commit 7afbdd4 into main Oct 15, 2026
3 checks passed
@thesiti92
thesiti92 deleted the ui/copy-text-kit branch October 15, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants